Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new component Segmented #6697

Merged
merged 12 commits into from
Aug 7, 2024
Merged

feat: new component Segmented #6697

merged 12 commits into from
Aug 7, 2024

Conversation

vagusX
Copy link
Member

@vagusX vagusX commented Aug 5, 2024 •
edited
Loading

image

@vagusX vagusX changed the base branch from master to feature August 5, 2024 06:32
@vagusX vagusX changed the base branch from feature to master August 6, 2024 02:29
@vagusX vagusX force-pushed the feat/new-component-segmented branch from ea7a689 to 8cab611 Compare August 6, 2024 02:33
@vagusX vagusX force-pushed the feat/new-component-segmented branch from 8cab611 to bf9c718 Compare August 6, 2024 03:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

Size Change: +11.5 kB (+3.2%)

Total Size: 370 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 198 kB +5.57 kB (+2.9%)
./lib/bundle/antd-mobile.umd.js 152 kB +5.54 kB (+3.78%)
./lib/bundle/style.css 18.5 kB +371 B (+2.05%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.42 kB

compressed-size-action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./lib/bundle/antd-mobile.es.js 107.57 KB (+4.01 KB 🔺) 2.2 s (+3.88% 🔺) 943 ms (+8.49% 🔺) 3.1 s

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6697.surge.sh

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.66%. Comparing base (cf550e4) to head (578faee).
Report is 37 commits behind head on master.

Files Patch % Lines
src/components/segmented/segmented.tsx 96.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6697      +/-   ##
==========================================
+ Coverage   92.34%   92.66%   +0.31%     
==========================================
  Files         318      331      +13     
  Lines        6910     7169     +259     
  Branches     1729     1792      +63     
==========================================
+ Hits         6381     6643     +262     
+ Misses        493      490       -3     
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagusX vagusX requested a review from afc163 August 6, 2024 09:22
@zombieJ zombieJ merged commit ff66628 into master Aug 7, 2024
8 checks passed
@zombieJ zombieJ deleted the feat/new-component-segmented branch August 7, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@miracles1919 miracles1919 Awaiting requested review from miracles1919

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vagusX @zombieJ